Mateusz Burzyński
Mateusz Burzyński
@hzuo Im still not sure if I want to merge this, requested changes after code review are really rather cosmetic, so you might try to adjust the code accordingly. No...
@hzuo sorry for a delay - I've created a PR i was planning to do for quite some time. I'd love your input there - https://github.com/Pomax/react-onclickoutside/pull/246
@augbog yeah, i need to finish the #246 (wanna help with that? 😉 ), but got occupied with tons of other OSS work and somehow never got back to it...
I've created a PR i was planning to do for quite some time. I'd love your input there - https://github.com/Pomax/react-onclickoutside/pull/246
Could you prepare a codesandbox illustrating the problem?
> The most obvious thing missing in this PR would be the necessary updates to the README.md with a linkback to the "if you're looking for the v6 docs, click...
> One thing that should be fixed in this PR as well is the prepublish command, which uses totally windows-incompatible commands. Also, give that we've been on npm5 for a...
Im not sure if I understand what do you mean, could you please give an example code snippet with the expected behaviour explained?
I guess it would require using [hoist-non-react-statics](https://github.com/mridgway/hoist-non-react-statics)