Mateusz Burzyński

Results 1531 comments of Mateusz Burzyński

The likely problem is that the memory is still preserved between those navigations so Emotion things those elements are still in the DOM as they are still registered in the...

Yeah, exactly. I can't add it to Emotion because any data attribute they might have is kinda theirs and I don't want to depend on it directly. But it can...

> Should we have a changeset associated with this? This is purely an internal change - inconsequential for end users, so I'd say this doesn't need a changeset.

Have you confirmed that this performs better in all modern engines?

It looks good, cc @emmatown

Are you using a tab-based indentation in the affected files by any chance?

Both should be improved/fixed. Thanks for raising an issue. I might not have time to implement this myself though - PRs are welcome 😉

> STDERR 🎁 error @emotion/styled the entrypoint tags isn't included in the published files for this package, please add it to the files field in the package's package.json You need...

I didn't get to the bottom of this but it looks like a potential Parcel bug. 1. `rootShouldForwardProp` [here](https://github.com/mui/material-ui/blob/029eb3b1f4837591e729779da9a82f0a66187770/packages/mui-material/src/styles/styled.js#L13) is an empty object (`{}`). This leads to a crash -...

I can fix that issue but I need a little bit more context on it. What is this [`Shadows`](https://github.com/mui/material-ui/blob/58d14a69e8c5d9c69ccd30aa60e18a098bcdb26e/packages/mui-material/src/styles/shadows.d.ts#L1-L27) type even supposed to represent here? Why it's typed like this?...