and-bible icon indicating copy to clipboard operation
and-bible copied to clipboard

Backup and Restore dialog proposal

Open agrogers opened this issue 3 years ago • 8 comments

  1. The original 'Share or Backup' text is probably not necessary. It describes precisely what they can do but they will work that out soon enough just by clicking on the button so it probably isn't necessary
  2. This form would allow backing up all three types of data in one action not three.
  3. The restore option needs to act like a radio button (only one of the two can be selected at once). On my device it opens a screen that allows me to get to Drive or my phone storage. I assume it's similar on other device.
  4. The Restore button text could change depending on what option is selected (eg 'Restore Documents from')

AndBible Suggestions-Backup

Additional

agrogers avatar Jun 19 '21 09:06 agrogers

How should combined backup / restore work?

tuomas2 avatar Jun 19 '21 13:06 tuomas2

Um, what is a 'combined' backup/restore?

agrogers avatar Jun 19 '21 14:06 agrogers

When you toggle multiple items and press "Share or Backup to...", what happens? Does it create a zip file containing both files? I guess Android allows saving only one file per time with file chooser intent. I might be wrong though.

tuomas2 avatar Jun 19 '21 14:06 tuomas2

Ah, i get it. The issue doesn't apply to 'restore' since i suggested you implement the checkboxes like radio buttons - only one can be true. Could possibly do that for the Backup as well.

But i thought you would do the same as you do now.

  1. Ask the user where they want to save the file(s)
  2. Prepare the first file
  3. Upload it
  4. Prepare the second file
  5. Upload it
  6. Tell the user they can sleep easy tonight.

That's not possible?

agrogers avatar Jun 19 '21 15:06 agrogers

Well chained operation is indeed possible

tuomas2 avatar Jun 19 '21 15:06 tuomas2

I could consider implementing this after 3.4 is released (not waiting to 3.5). Could you compile list of necessary strings for this feature so we can send them to translation? (pull request that changes values/strings.xml would be best :-) )

tuomas2 avatar Jun 21 '21 08:06 tuomas2

I like RadioButtons more and changed it like this: image

tuomas2 avatar Sep 22 '22 13:09 tuomas2

Radio buttons are better for the current implementation. If we ever allow backing up multiple items then checkboxes should probably come back.

agrogers avatar Sep 22 '22 13:09 agrogers