anchor-token-contracts icon indicating copy to clipboard operation
anchor-token-contracts copied to clipboard

[BUG] Governance contract, Query bug

Open kaisbaccour opened this issue 3 years ago • 0 comments

Hey guys, I Found this issue while copying your code to terra-vegas casino This issue is a confusing query issue in the governance contract. The confusion happens in this line https://github.com/Anchor-Protocol/anchor-token-contracts/blob/main/contracts/gov/src/contract.rs#L598

This happens when the voting period is finished but no tx has happened yet to update the state. This could be mitigated by adding a new condition on the query function to make sure we send the right response. I opened a PR here https://github.com/Anchor-Protocol/anchor-token-contracts/pull/31 I put the Status to Expired because I did not want to add a new PollStatus::WaitingOnTransactionToEndPoll. But I believer a new status should be there to better describe the Poll status (Waiting On Transaction To End Poll)

Please check the Pull request

kaisbaccour avatar Mar 05 '22 12:03 kaisbaccour