SaveFrom conflict

[SuperZombi]

Browser

Google Chrome

Browser Version

105.0.5195.127

Extension or Userscript?

Extension

Extension/Userscript Version

3.0.0.6

Video link where you see the problem

https://www.youtube.com/watch?v=* (ALL)

What happened?

After the redesign of YouTube, the extension began to conflict with SaveFromNet (the number of dislikes is displayed instead of likes).

How to reproduce/recreate?

Install UserScript SaveFromNetHelper

Will you be available for follow-up questions to help developers diagnose & fix the issue?

Yes

[ErykDarnowski]

I think I've figured out what's going on here.

1. The dislikes being shown in place of likes is caused by how getLikeButton() and getDislikeButton() functions get like/dislike elements. To be exact, it's caused by them accessing the first child (children[0]) of the element returned by getButtons(). This makes the getLikeTextContainer() and getDislikeTextContainer() functions (as they use the above mentioned functions) target the incorrect elements when trying to set like/dislike numbers. This could be fixed by something like this:

function getLikeButton() {
  const segmentedLikeButton = getButtons().getElementsByTagName(
    "ytd-segmented-like-dislike-button-renderer"
  )[0]?.children[0];
  return segmentedLikeButton !== null
    ? segmentedLikeButton
    : getButtons().children[0];
}

function getDislikeButton() {
  const segmentedDislikeButton = getButtons().getElementsByTagName(
    "ytd-segmented-like-dislike-button-renderer"
  )[0]?.children[1];
  return segmentedDislikeButton !== null
    ? segmentedDislikeButton
    : getButtons().children[1];
}

2. The like/dislike ratio bar offset is caused by the #actions element stretching. This is similar to what was happening in issue #733. Unfortunately, the fix I implemented for it (in this PR) didn't account for elements being added by other extensions. A solution to this would be combining the fix in my PR with putting both ytd-segmented-like-dislike-button-renderer and ryd-tooltip elements in to a <div> with maring-right: 8px (to fix the gap between like/dislike and share buttons).

---

Still, these need a bit more testing before implementation.

---

Resources

• https://github.com/Anarios/return-youtube-dislike/issues/801#issuecomment-1325814736

[dynoChris]

I confirm. There is a problem. Is it planned to be fixed? Really needed.

[VetaLioSTV]

Same scenario for competitor Y2mate extension, which causing same issue.

[ronny941]

i hope you find a solution for fix this bug

[ronny941]

in the settings of savefrom you can remove the download for youtube and then the extension works again

[ronny941]

on chrome brave and edge it's not necessary because the download from youtube is blocked on the chromium browsers by google only on firefox this extension works with youtube and you can download from it by using this extension

[ErykDarnowski]

Hey @ronny941, you don't need to add any more info! I'm pretty sure I have enough information to implement a fix 😄

Just give me a bit more time!

[ronny941]

ok i understand sorry