return-youtube-dislike icon indicating copy to clipboard operation
return-youtube-dislike copied to clipboard

Add safari extension

Open CamilleScholtz opened this issue 3 years ago • 8 comments

I know there is #133, but that PR seems a bit stale. This one is up to date with master, and makes use of webpack to build the safari extension.

Note that I have only tested this on MacOS, and not iOS.

Closes #127.

CamilleScholtz avatar Jan 15 '22 00:01 CamilleScholtz

if someone tests this on iOS that would be really cool

aryavsaigal avatar Jan 16 '22 20:01 aryavsaigal

https://github.com/Anarios/return-youtube-dislike/pull/133 implements iOS and is only stale because it "requires 6 reviews to be merged" and no one is looking at it. These changes are better merged there

rdev avatar Feb 03 '22 09:02 rdev

@rdev #133 is stale because it had merge conflicts for months now, not because "no one is looking at it".

Now that #133 has been closed due to inactivity maybe its time to combine both PRs into a single one and merge it into the main branch.

marcizhu avatar Feb 04 '22 22:02 marcizhu

@marcizhu it was ready to merge before the conflicts

rdev avatar Feb 05 '22 04:02 rdev

I totally agree on that, but then there were merge conflicts and that's why it never got merged. Regardless, lets not go off-topic. Can we please get either #133, #443 or a mix of both merged so that we can have an extension for Safari? 😄

marcizhu avatar Feb 05 '22 14:02 marcizhu

Why no one is looking at it?

iyeldinov avatar Feb 15 '22 16:02 iyeldinov

Anything new here?

iMonZ avatar May 01 '22 09:05 iMonZ

@iMonZ you can just download free Userscripts app from the App Store https://apps.apple.com/de/app/userscripts/id1463298887?l=en

enable it in Safari then click on "Userscript" on the install page https://returnyoutubedislike.com/install

works great for me both on Mac and iPhone!

mishushakov avatar May 01 '22 10:05 mishushakov

Closing due to inactivity. Someone can make the same PR for the fourth time which can then be ignored again.

CamilleScholtz avatar Feb 27 '23 19:02 CamilleScholtz