Azizul Haque Ananto
Azizul Haque Ananto
Hi @shimondoodkin thanks for the tests. I found some issues for server termination in the tests. I see you are trying to fix them, thanks for that! 🙌 But if...
Hi @shimondoodkin I have fixed the server close issue in this PR => https://github.com/Ananto30/zero/pull/28 (exactly these lines [server.py#111](https://github.com/Ananto30/zero/pull/28/files#diff-2f50c53b4b8570b5bb3652e6f0cf315fbd8df68f565bfe6eb290cd094067d2f0R111), [server.py#137](https://github.com/Ananto30/zero/pull/28/files#diff-2f50c53b4b8570b5bb3652e6f0cf315fbd8df68f565bfe6eb290cd094067d2f0R137) and making fixtures in specific folders [tests/single_server/conftest.py#14](https://github.com/Ananto30/zero/pull/28/files#diff-7954c1f549d417728a60c061237b181c1346e959246dc432c6156daa14856091R14), [tests/multiple_servers/conftest.py#10](https://github.com/Ananto30/zero/pull/28/files#diff-315f26a672e579ac3beecd499f0ad8905ba21170119c39e8320fa370916d249cR10)) So I already...
@shimondoodkin very good point! I have introduced `polling` for the sync client. For the async client, there are still some issues. And for the server, I haven't tried polling. Maybe...
@alpondith Thanks for the PR! 🙌 Is it possible to move the package.json and lock file in the docs folder?
@depfu refresh
@depfu recreate
Nice and neat work! :raised_hands:
Hi @martincpt , very few lines are missing in code coverage. I can merge without them if you want. Then will update and make a release.
Sorry @martincpt I was caught up with many things. Let me merge this and test. I will update the tests if needed. Thanks for the good work!
@depfu refresh