bookshelf-action icon indicating copy to clipboard operation
bookshelf-action copied to clipboard

Ability to add notes as comments

Open bjork24 opened this issue 2 years ago • 3 comments

First, thank you for creating this project! It's very creative and useful. I have an idea for an additional feature. I like to write a sentence or two summarizing each chapter as I finish them, and I'm sure others would find it useful to leave notes or summaries as well. Could you add the ability to leave a note as an issue comment? Perhaps it would make sense to prepend Note: so the github action knows how to process it. Thanks!

bjork24 avatar May 11 '22 13:05 bjork24

I think this is an amazing idea. I love taking notes and I end up ruining my books by highlighting and underlining things (though I use pencils, I swear!) so using GitHub comments for notes sounds like the perfect solution. I'll work on this!

AnandChowdhary avatar May 11 '22 14:05 AnandChowdhary

I like the idea of notes too. I've been adding notes as comments to my github issues. Nothing happens with them, they just exist as a comment on the issue. What would the github action do with the notes?

ciwchris avatar May 11 '22 16:05 ciwchris

Currently, if you have a number in the notes, the Action tries to parse it to figure out the page number, e.g., "I'm on page 200" will mark a 500-page book as 40% completed. So you're right, you can already just comment on the issues as long as they don't have a number in them. But of course, we can have a rule, like the Note: prefix, that would ignore numbers.

AnandChowdhary avatar May 11 '22 16:05 AnandChowdhary

⚠️ This issue has not seen any activity in the past 2 months so I'm marking it as stale. I'll close it if it doesn't see any activity in the coming week.

FindingAnand avatar Sep 06 '23 00:09 FindingAnand

⚠️ This issue has not seen any activity in the past 2 months so I'm marking it as stale. I'll close it if it doesn't see any activity in the coming week.

FindingAnand avatar Nov 06 '23 00:11 FindingAnand