lexicon icon indicating copy to clipboard operation
lexicon copied to clipboard

Published 20 hours ago • verified publisher icon AnalogJ

Added support for German DNS provider Core Networks

Open MasinAD opened this issue 4 years ago • 17 comments

I implemented support for the German DNS provider Core Networks. They provide a simple API with a few caveats (most importantly rate limiting logins).

My implementation passes all the tests:

===================== 27 passed, 2 skipped, 6 warnings in 105.94s (0:01:45) ======================

One major problem might be that the API requires changes to be committed which is a slow operation. That's why I decided to put the commit call in the destructor. During my tests I experienced that the destructor wasn't called anymore because Python was shutting down. Maybe there's a better solution.

MasinAD avatar Apr 24 '20 17:04 MasinAD

Okay, I don't get it. My _filter_post_data_parameters seems to get ignored as the post data is still included in the recording. Without the real login data the simulated tests always fail. With login data the simulated and live tests succeed.

OTOH, I got it running with Python 2.7.

MasinAD avatar Apr 24 '20 22:04 MasinAD

Hello @MasinAD, are you still willing to finish the PR?

adferrand avatar Jun 01 '20 22:06 adferrand

Hello @MasinAD, are you still willing to finish the PR?

Oh, sorry, yes, I am. I will finish it at the weekend.

MasinAD avatar Jun 02 '20 18:06 MasinAD

Hello @MasinAD, any update here?

adferrand avatar Jul 08 '20 13:07 adferrand

Hello @MasinAD, quick reminder if you have the time to finish your PR :)

adferrand avatar Sep 07 '20 20:09 adferrand

Hello @MasinAD, quick reminder if you have the time to finish your PR :)

Sorry for the late answer. I have to time to work on this again and I am motivated to work on this again.

MasinAD avatar Jan 07 '21 12:01 MasinAD

Sorry for the late answer. I have to time to work on this again and I am motivated to work on this again.

@MasinAD Hi, what is the current state of the PR?

renne avatar Mar 28 '22 20:03 renne

@MasinAD Hi, what is the current state of the PR?

It fails 2 tests I cannot figure out how to fix but otherwise seems to work. I updated it to latest upstream.

MasinAD avatar Mar 29 '22 20:03 MasinAD

Hello @MasinAD! Thanks a lot for your update. Have you achieved the fix on the remaining tests? If so, the only thing to do to finish the PR is to update the cassettes for the integration tests, and we are good to go!

adferrand avatar Apr 19 '22 10:04 adferrand

I thought I updated the cassettes. Are they outdated?

MasinAD avatar Nov 07 '22 20:11 MasinAD

@adferrand @MasinAD Why is the pull-request failing?

renne avatar Feb 02 '23 14:02 renne

I think there was an issue with tox, not supporting anymore the whitelist_externals parameter. I just hit that one. Master branch is updated, so we should rebase the PR and see if it solves the issues.

adferrand avatar Feb 02 '23 22:02 adferrand

Ummm, do I have anything to do? How do I rebase the PR?

MasinAD avatar Feb 09 '23 21:02 MasinAD

@adferrand @MasinAD

Are there any plans to go on with this PR?

renne avatar Jun 28 '23 13:06 renne

Well, this PR fell in the limbo given that the tests are failing and have never been fixed.

Either the original contributor can work on the issue or myself if you provide me valid credentials to actually test the provider.

adferrand avatar Jun 28 '23 13:06 adferrand

@adferrand How can I send you a private message with credentials?

renne avatar Jun 28 '23 16:06 renne

If someone can tell me how to rebase the PR I can work on fixing stuff.

MasinAD avatar Jun 28 '23 18:06 MasinAD