lexicon icon indicating copy to clipboard operation
lexicon copied to clipboard

Update the URI for Porkbun's API

Open erik434 opened this issue 1 year ago • 0 comments

The new URI is live now; the old one will stop accepting API calls on December 1st, according to this email I got from them:

image

Their documentation already references the new URI and confirms that the old one is deprecated: https://porkbun.com/api/json/v3/documentation

I confirmed the new URI seems to work here by running a few manual commands (like lexicon porkbun list <mydomain> A), and was also able to use the updated porkbun.py to generate new Let's Encrypt certs via dehydrated in a live TKL Core VM.

As I was updating the Porkbun test cassettes, I ran into Porkbun's rate limits, so ended up adding retries when we get a 503 response, following a pattern I saw used in the DNSMadeEasy provider. This lets the tests pass, but the 503's clutter up the recorded data, so I also filtered those responses out in _filter_response.

Please take a look and let me know if there's anything else I should do here. Thanks!

erik434 avatar Oct 14 '24 00:10 erik434