Emma Fabre

Results 138 comments of Emma Fabre

Ah yes I see, would you mind sending a PR to `develop` for this?

Looks good! Smart way to solve this. Can you add a quick test for this in the TemplatingTest class? With and without arguments passed to `section`

You're correct it doesn't exist yet, the reason it wasn't implemented is I'm not really familiar with Twig extensions and left it out for now. If you want to PR...

Will add a way to override the default saltshaker in kickstart

It seems Laravel is resolving `Flickering\Flickering` to `Flickering\Facades\Flickering`, is there any `App::bind` or alias set that that way ?

Yeah but that's if you're going to use the Flickering facade directly, if you're going to use the class directly by injection, you don't need it.

Can you show me the full code of the controller ?

Well that makes sense no, how would you have a child to a text node ?

You should do a `composer update` to update the librarie's dependencies first – there were some changes upstream in the Imagine library and I think some of the buggy behaviors...

Yes and no, I do plan to update _parts_ of the package to Laravel 5.4 (everything gettext related) but the Eloquent part I think is nowadays handled better by packages...