d3act icon indicating copy to clipboard operation
d3act copied to clipboard

Bubble chart text min value

Open cescoferraro opened this issue 8 years ago • 4 comments

The bubble chart needs to have a value bigger than 15 to display text. This value is too random, should not this be a prop?

https://github.com/AnSavvides/d3act/blob/master/src/components/BubbleChart.js#L15

cescoferraro avatar Mar 01 '17 22:03 cescoferraro

I had this problem too. I just added 15 to all my values. It may not be the right way but it helped me.

sghgh1996 avatar Oct 10 '17 09:10 sghgh1996

Good point! If you've got time to, a PR to address this would be great!

AnSavvides avatar Oct 10 '17 09:10 AnSavvides

Actually I really like to do that. Do I remove grater than 15 restriction or make it as a prop? I think removing grater than 15 restriction would be good.

sghgh1996 avatar Oct 10 '17 09:10 sghgh1996

I believe I set a limit because smaller bubbles having text would have the text spilling over - as long as we can add an ellipsis or something like that to ensure it doesn't spill out, sure thing!

AnSavvides avatar Oct 10 '17 09:10 AnSavvides