TFTrue icon indicating copy to clipboard operation
TFTrue copied to clipboard

Players with < or > in their name can screw up log uploading

Open sapphonie opened this issue 3 years ago • 4 comments

char msg[128];
V_snprintf(msg, sizeof(msg),
   "\"%s<%d><%s><%s>\" triggered \"chargeready\"\n",
   pInfo->GetName(), pInfo->GetUserID(),
   pInfo->GetNetworkIDString(), szTeam);
engine->LogPrint(msg);

pInfo->GetName() does not do any sanitization 😬

sapphonie avatar Aug 25 '21 21:08 sapphonie

Shouldn't this be handled properly by the parser with a correct regex?

AnAkkk avatar Sep 20 '21 08:09 AnAkkk

What parser? If it's supposed to be getting handled by logstf, it isn't.

sapphonie avatar Sep 21 '21 01:09 sapphonie

Yeah, I would guess that logs.tf is supposed to handle such cases.

AnAkkk avatar Oct 17 '21 18:10 AnAkkk

🤷

I don't believe this is an issue with the logstf sourcemod plugin

sapphonie avatar Oct 17 '21 18:10 sapphonie