visiblebarriers icon indicating copy to clipboard operation
visiblebarriers copied to clipboard

feat: added config menu using modmenu and cloth_config lib

Open GaeaKat opened this issue 1 year ago • 7 comments

This adds a config menu, using ModMenu and ClothConfig.

The resulting menu looks like the following: Screenshot 2024-10-06 at 2 49 46 AM

GaeaKat avatar Oct 06 '24 02:10 GaeaKat

This is to hopefully add towards #69

GaeaKat avatar Oct 06 '24 02:10 GaeaKat

does this make cloth a required dependency? I would rather avoid that

AmyMialee avatar Oct 06 '24 16:10 AmyMialee

does this make cloth a required dependency? I would rather avoid that

Only when modmenu is present. When it is not present, it runs fine without it in the modlist

GaeaKat avatar Oct 06 '24 16:10 GaeaKat

basically every pack has modmenu though?

AmyMialee avatar Oct 06 '24 16:10 AmyMialee

basically every pack has modmenu though?

Fair, though I don't see many that have one without the other either. But sorry if the PR did it in a way that wasn't appropriate then! :)

GaeaKat avatar Oct 06 '24 16:10 GaeaKat

Would it be prefered if I made it with a custom config screen instead? I used cloth as I thought it was a pretty standard library for inclusion, and such.

GaeaKat avatar Oct 06 '24 16:10 GaeaKat

I usually use something like midnight config or a custom thing just to avoid needing a library Smaller mapmaking packs are less likely to already have cloth

AmyMialee avatar Oct 13 '24 17:10 AmyMialee