amsterdam-styled-components icon indicating copy to clipboard operation
amsterdam-styled-components copied to clipboard

Published 20 hours ago • verified publisher icon Amsterdam

Add Toggle component

Open jasperswart opened this issue 3 years ago • 1 comments

we have to wait for changes in design: until then DO NOT MERGE!

Screenshot 2021-03-18 at 11 19 09
  • [ ] You've added or updated the README.mdx of the story of the component
  • [x] You have been following the guidelines, written in the README file
  • [x] Your code has the necessary tests written
  • [x] You've exported the component in index.ts
  • [x] You have updated the CHANGELOG.md unreleased sections

Be kind to code reviewers, please try to keep pull requests as small and focused as possible :)

jasperswart avatar Mar 18 '21 10:03 jasperswart

Also, the rename of Toggle to MenuToggle is a breaking change. It's less intrusive to Not rename the Toggle button and just give another name to the newly created Toggle like I suggested:

Maybe just recreate the PR and don't rename the MenuToggle component and instead just name the Toggle to ToggleButton or something?

timvanoostrom avatar Mar 29 '21 14:03 timvanoostrom