Reactive-Resume
Reactive-Resume copied to clipboard
feat: separate links option to reduce section item height
I just discovered this amazing project and I would like to help. I am rusty from the little experience I've had with React. I welcome any advice and opinions.
This is a Draft of an option to regroup links of section's items:
This is a first idea, but it would also be possible to have the option at the section level. I suppose it would be a good idea to wrap this ternary condition to avoid reading heaviness.
I'm waiting for opinions/suggestions/approvals to complete this work.
To do:
- [x] Adapt all templates with the features
Rework: Better code style
I moved the option at the section level, the toggle is now present in the dropdown menu per section to have granular options
I finished the full implementation
Any reason to close this merge request? @AmruthPillai
My apologies, I wanted to merge this too, but there was a conflict. I ran the wrong command which closed the PR. Will update it to the latest branch and get this merged ASAP. Thank you so much for your efforts and the feature, it really is a very useful option! <3
Owner
Sure with pleasure! Have you any suggestions to improve it? I will do the rebase as soon as possible 😃
No, looks really good. I just tried it out locally and works perfectly.
☁️ Nx Cloud Report
CI is running/has finished running commands for commit fe550ccc3683065665ef3170f06abefe6faa2ab0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.
📂 See all runs for this CI Pipeline Execution
🟥 Failed Commands |
---|
nx run-many -t lint |
Sent with 💌 from NxCloud.