Reactive-Resume icon indicating copy to clipboard operation
Reactive-Resume copied to clipboard

feat: separate links option to reduce section item height

Open jzaehrin opened this issue 11 months ago • 2 comments

I just discovered this amazing project and I would like to help. I am rusty from the little experience I've had with React. I welcome any advice and opinions.

This is a Draft of an option to regroup links of section's items:

screenshot-2024-03-21_17-19-09 screenshot-2024-03-21_17-20-39 screenshot-2024-03-21_17-21-12 screenshot-2024-03-21_17-21-26

This is a first idea, but it would also be possible to have the option at the section level. I suppose it would be a good idea to wrap this ternary condition to avoid reading heaviness.

I'm waiting for opinions/suggestions/approvals to complete this work.

To do:

  • [x] Adapt all templates with the features

jzaehrin avatar Mar 21 '24 20:03 jzaehrin

Rework: Better code style

jzaehrin avatar Mar 24 '24 20:03 jzaehrin

I moved the option at the section level, the toggle is now present in the dropdown menu per section to have granular options

screenshot-2024-03-25_17-26-54 screenshot-2024-03-25_17-27-05

I finished the full implementation

jzaehrin avatar Mar 25 '24 16:03 jzaehrin

Any reason to close this merge request? @AmruthPillai

jzaehrin avatar May 20 '24 14:05 jzaehrin

My apologies, I wanted to merge this too, but there was a conflict. I ran the wrong command which closed the PR. Will update it to the latest branch and get this merged ASAP. Thank you so much for your efforts and the feature, it really is a very useful option! <3

AmruthPillai avatar May 20 '24 14:05 AmruthPillai

Owner

Sure with pleasure! Have you any suggestions to improve it? I will do the rebase as soon as possible 😃

jzaehrin avatar May 20 '24 14:05 jzaehrin

No, looks really good. I just tried it out locally and works perfectly.

AmruthPillai avatar May 20 '24 15:05 AmruthPillai

☁️ Nx Cloud Report

CI is running/has finished running commands for commit fe550ccc3683065665ef3170f06abefe6faa2ab0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx run-many -t lint

Sent with 💌 from NxCloud.

nx-cloud[bot] avatar May 20 '24 15:05 nx-cloud[bot]