Reactive-Resume icon indicating copy to clipboard operation
Reactive-Resume copied to clipboard

[Bugfix] Instantiate Link with inclusive set to false

Open CorreyL opened this issue 1 year ago • 1 comments

If the maintainers of Reactive Resume agree with the points raised in my issue here:

https://github.com/AmruthPillai/Reactive-Resume/issues/1726

This PR will configure Tiptap to behave similar to other text editors when adding hyperlinks.

Before

reactive-resume

After

reactive-resume-change


⚠️Possible Undesired Side Effect

I will note that this may negatively impact users who wish to add text after adding a hyperlink to the editor:

Before

link-after-text before

After

link-after-text after

And as such, I will understand if the Reactive Resume maintainers see this as an overall negative change.

CorreyL avatar Jan 21 '24 17:01 CorreyL

To avoid the undesired side effect mentioned above, perhaps I could extend this implementation to instantiate a new component?

Rather than the simple window.prompt here:

https://github.com/AmruthPillai/Reactive-Resume/blob/9298a7473e9f1cf9e87792c872c0511ff6d3f8a8/libs/ui/src/components/rich-input.tsx#L116-L119

I could implement a new modal similar to other text editors, where there is a second input element that allows for the intended text to be added as well:

Microsoft Word

image

Google Docs

image

CorreyL avatar Jan 21 '24 18:01 CorreyL