Amjad Ben Hedhili
Amjad Ben Hedhili
Is it ok to have an overload for integer types of arbitrary sizes. Shouldn't the input be byte strings.
> Please add a changelog entry, then this can be merged. Is this needed, from the user's perspective nothing changed. > > Is it ok to have an overload for...
```nim import std/base64 var x = @[72, 101, 108, 108, 111] # Hello let e = encode(x) x[0] += 256 assert encode(x) == e ```
I tried `T: range[0..255]|uint8|char` but this doesn't work even for `encode [10]`.
Should I change `T: byte|char` then and deprecate the `T: SomeInteger` overload ?
> I tried `T: range[0..255]|uint8|char` but this doesn't work even for `encode [10]`. Why doesn't it work ?
cc @Varriount ^.
@Araq, What about code like `encode @[111, 113, 32]` ? should it be deprecated ?
@Araq is this fine ?
Can this be merged now ?