Amit Moryossef

Results 201 comments of Amit Moryossef
trafficstars

The problem is that the version we have on PyPi and the one in the repository are out of sync, and I didn't keep pushing to pypi (and I always...

lots of comments... in the future it would be helpful if you keep editing the same comment or handful. When you: ```py tfds.load('dgs_corpus', split=["train:2%"]) ``` What happens is that first...

Ok, so to me it seems like you are not using appropriate config > Like maybe there's a setting in there to not load every file but just a list...

Just dropping notes here, seems like: 1. we need to use `tf.io.gfile` in more places 2. for signbank, we are opening a file, which is fine, but for sign2mint, the...

Thanks! The contribution process is quite simple, you can see many past PRs: https://github.com/sign-language-processing/sign-language-processing.github.io/pulls?q=is%3Apr+is%3Aclosed Mainly, to add text, it involves editing this large markdown file with all of the content...

Thanks! One possible improvement I see, is instead of: https://github.com/awslabs/sockeye/blob/main/sockeye/model.py#L665C13-L665C79 To run the multiplications in parallel: ```py futures = [torch.jit.fork(fol, decoder_out) for fol in self.factor_output_layers] outputs += [torch.jit.wait(fut) for fut...

With the `--use-cpu` flag, we get > [INFO:__main__] Processed 1 lines. Total time: 1.6748, sec/sent: 1.6748, sent/sec: 0.5971 Compared to an A100 GPU: > [INFO:main] Processed 1 lines. Total time:...

Since it seems like the CPU time is huge, I list the CPU timing: ``` Self CPU time total: 18.575s Self CUDA time total: 27.326ms ``` Profile output: ``` -------------------------------------------------------...

with torch 2.3.0, on GPU: >[INFO:__main__] Processed 1 lines. Total time: 2.8488, sec/sent: 2.8488, sent/sec: 0.3510 on CPU: > [INFO:__main__] Processed 1 lines. Total time: 1.6967, sec/sent: 1.6967, sent/sec: 0.5894...

hi @brandyscarney ! long time in this picture, it is auto, rtl, and auto. the first line should behave like the second. ![image](https://github.com/ionic-team/ionic-framework/assets/5757359/60ff3e66-9c14-472e-a140-bef3d09b889a) but dir=auto does not propagate to the...