gym-mtsim icon indicating copy to clipboard operation
gym-mtsim copied to clipboard

Low bound of spaces.Box

Open sadimoodi opened this issue 3 years ago • 1 comments

Hello @AminHP , why is the low bound of balance, equity and features is -np.inf? see code:

        self.observation_space = spaces.Dict({
            'balance': spaces.Box(low=-np.inf, high=np.inf, shape=(1,)),
            'equity': spaces.Box(low=-np.inf, high=np.inf, shape=(1,)),
            'margin': spaces.Box(low=-np.inf, high=np.inf, shape=(1,)),
            'features': spaces.Box(low=-np.inf, high=np.inf, shape=self.features_shape),
            'orders': spaces.Box(
                low=-np.inf, high=np.inf,
                shape=(len(self.trading_symbols), self.symbol_max_orders, 3)
            )  # symbol, order_i -> [entry_price, volume, profit]
        })

shouldnt low bound start from zero? meaning its impossible for balance be below 0

sadimoodi avatar Jan 27 '22 09:01 sadimoodi

Yes, it should start from zero. Thanks for noticing!

AminHP avatar Jan 29 '22 22:01 AminHP