brisk icon indicating copy to clipboard operation
brisk copied to clipboard

i18n

Open bovirus opened this issue 8 months ago • 10 comments

@AminBhst

Thanks for the prgram.

Could you please consider to add a multilanguage UI?

Thanks.

bovirus avatar Apr 21 '25 09:04 bovirus

Hey. Sure I'll work on it

AminBhst avatar Apr 21 '25 09:04 AminBhst

@AminBhst

If you are agree I can help with Italian language and with improvements about Inno Setup installer script (.iss file).

bovirus avatar Apr 21 '25 09:04 bovirus

Sure absolutely! I'll have to setup the i18n first then I'll let you know so that you can work on the Italian translations. What improvements on the .iss file are you thinking about?

AminBhst avatar Apr 21 '25 09:04 AminBhst

@AminBhst

I think that I can prepare the .iss file to accept in the future definition of additional language. I can also setup in .iss file some automatic task (get version from main exe. latest update about copyright with current year, etc). Could you confirm that are you using Inno Setup 6.4.0 (I checked it with my tools your exe installer)?

bovirus avatar Apr 21 '25 10:04 bovirus

Yeah that would be great! I'm not sure exactly which version is used for Inno Setup. The workflow just installs it using choco. I assume it always installs the latest version

AminBhst avatar Apr 21 '25 10:04 AminBhst

@AminBhst

Example of some current issues in the installer that I can fix in .iss.

  • Exe file installer proprties

Image

  • Windows program list program icon

In Windows program list program icon is not set

Image

  • Installer based on Inno Setup 6.4.0

Your installer seems based on Inno Setup 6.4.0

Image

I propose to update to Inno Setup 6.4.2.

bovirus avatar Apr 21 '25 10:04 bovirus

Oh didn't know these issues existed. Then I'd appreciate your help. The iss file is located here if you wanted to change it. The job steps replace the placeholders in this file with the appropriate values.

AminBhst avatar Apr 21 '25 10:04 AminBhst

@AminBhst

Improve Inno Setup installer script

https://github.com/AminBhst/brisk/pull/97

  • Exe instller file properties

Image

  • Windows program list

Image

bovirus avatar Apr 21 '25 16:04 bovirus

@AminBhst

Are there a plan relase date for multilanguage GUI?

bovirus avatar May 01 '25 08:05 bovirus

I will soon start working on it but may take some time because I'm quite busy.

AminBhst avatar May 01 '25 09:05 AminBhst

@bovirus I've completed the i10n work. You can now start working on the Italian translations. Take a look at this file. All you need to do is to create a file named app_it.arb based on the base english file and translate it. The file should be in the same directory as app_en.arb

AminBhst avatar May 11 '25 23:05 AminBhst

@AminBhst

Is it right i10n folder name (and not i18n) here

https://github.com/Brisk-Apps/brisk/tree/main/lib/l10n

bovirus avatar May 12 '25 05:05 bovirus

Yes it's l10n

AminBhst avatar May 12 '25 08:05 AminBhst

@AminBhst

Thanks. I posted a PR with Italian language.

bovirus avatar May 12 '25 08:05 bovirus

Thanks. It will be available in the next release very soon

AminBhst avatar May 12 '25 08:05 AminBhst

@bovirus Now available in v2.2.3. There were parts of the UI that I'd forgotten the l10n for so I just used AI translations for them. Please check the file out and open a new PR if you noticed any bad translations

AminBhst avatar May 12 '25 21:05 AminBhst