AmboVent icon indicating copy to clipboard operation
AmboVent copied to clipboard

PR: Add support for L298N driver

Open RuairiSpain opened this issue 4 years ago • 3 comments

Description:

Add support for L298N driver boards

Checklist:

  • [X] I have run the code formatter with ./run_clang-format.sh (see main README.md for details on how)
  • [X] I have built the code in the Arduino IDE (or with the command-line tool) and pasted the build output below
  • [X] If I have touched any lines of code in the software, other than comments, I have incremented the version number string at the top of "ventilation_machine.ino" and updated the Software Changelog in the main AmboVent readme.

Arduino IDE build output:

Date and time I performed this build: YYYYMMDD-HHMMhrs
(git hash ???????) (IDE ?.?.??) (Arduino __ ? __)

Sketch uses 18140 bytes (59%) of program storage space. Maximum is 30720 bytes. Global variables use 1076 bytes (52%) of dynamic memory, leaving 972 bytes for local variables. Maximum is 2048 bytes.

RuairiSpain avatar May 01 '20 20:05 RuairiSpain

Please re-review your changes, it seems that you fixed some conflicts incorrectly

nimrod46 avatar May 05 '20 22:05 nimrod46

@RuairiSpain , I've edited the IDE output to be only the last 2 lines. I'll update the PR temlate shortly to make it more clear that's all we are looking for. Please update the information about the build output to indicate your Arduino IDE version and board you chose, as well as the git hash you built which corresponds to that output.

ElectricRCAircraftGuy avatar May 06 '20 15:05 ElectricRCAircraftGuy

pin 5 sw3 it is a input reset Alarm why are you using it a pwm is it needed yes but change this is a Physical Change and if needed The PWM header has only 3 Pins For This it needs 4 . image

Here Is the Change on My Version IF needed I can Update The Jumper is to Stop SW3 Shorting the Pin To GND (wire link)

I am on a debug version unconnected pins are the result on nightly version of kicad .

Arie001 avatar May 06 '20 16:05 Arie001