Ambient icon indicating copy to clipboard operation
Ambient copied to clipboard

fix: Collider::reverse_indices default now false

Open SK83RJOSH opened this issue 2 years ago • 3 comments

I don't believe indices need reversed at all. In my testing this has detrimental effects to every object tested; so I'm changing the default to false.

@FredrikNoren I think flip_normals ends up having the same effect as this, and in addition to that, both are probably not needed from my testing so we may want to drop them (it seems our winding order matches PhysX; your original issue with more details on this issue is long gone so I'm basing this on my observations with ~12 different objects).

SK83RJOSH avatar Feb 14 '23 20:02 SK83RJOSH

Actually scratch that! This does actually have a positive effect on collisions, but causes things to be inverted in the PVD. I'm going to leave this open for now, but we should investigate this at some point - because this makes PVD quite unusable. Definitely think we should still drop reverse_indices in favor of flip_normals only in any case; the end result is the same in terms of behavior...

SK83RJOSH avatar Feb 14 '23 21:02 SK83RJOSH

Uh yeah weird. We added the reverse_indices to get some other colliders to work. I agree that it feels like flip_normals should do the same, but I also suspect that we tested that first when we added this, so we probably need to verify that the other colliders work with just that flag before we remove reverse_indices (like big medium small, quixel etc.)

FredrikNoren avatar Feb 15 '23 08:02 FredrikNoren

Agreed! I'm probably not going to go too far down this rabbit hole until the weekend; but I definitely want to figure out why we need to change the indices at all. Based on the PVD rendering getting messed up I think there's a bug somewhere on our side that's leading to weird behavior with mesh/triangle shapes. When/if I figure it out I'll update this and run some more thorough tests.

SK83RJOSH avatar Feb 15 '23 18:02 SK83RJOSH

@SK83RJOSH any update?

philpax avatar Mar 27 '23 13:03 philpax

We are closing this as of now as the issue has gone stale and we are not sure if this is an actual issue.

If we experience problems with colliders in the future we will reopen this

ten3roberts avatar May 31 '23 08:05 ten3roberts