cpptraj icon indicating copy to clipboard operation
cpptraj copied to clipboard

Add support for new trajectory formats

Open drroe opened this issue 10 years ago • 20 comments

Add support for the following trajectory formats:

  • [x] TNG format
  • [ ] MMTF format http://mmtf.rcsb.org/
  • [x] Desmond DTR format

drroe avatar Nov 02 '15 18:11 drroe

See also

  • https://mailman-1.sys.kth.se/pipermail/gromacs.org_gmx-developers/2015-May/008300.html
  • https://github.com/mdtraj/mdtraj/blob/master/mdtraj/formats/xtc/src

rmcgibbo avatar Nov 02 '15 18:11 rmcgibbo

https://mailman-1.sys.kth.se/pipermail/gromacs.org_gmx-developers/2015-May/008300.html

The xdrfile package seems like a good option, esp. since it's available with major Linux distros. It can be an optional package for people who want xtc support (and the trr support via xdrfile is probably better than what I currently have in cpptraj).

https://github.com/mdtraj/mdtraj/blob/master/mdtraj/formats/xtc/src

These seem really cool - unfortunately I don't think the BSD license is compatible with GPL so cpptraj can't use these.

drroe avatar Nov 02 '15 18:11 drroe

I think GPL can use BSD, but not vice-versa, so cpptraj should be able to use them

p.s. +1 on supporting xtc however it is done :)

mpharrigan avatar Nov 02 '15 18:11 mpharrigan

  • xrd is the lower layer that handles getting floats/ints/bytes out of the file in an endian-independent way, but you still need to gromacs xtc code to decompress the coordinates.
  • the 2-clause bsd is compatible with the gpl http://www.gnu.org/licenses/license-list.en.html#ModifiedBSD

rmcgibbo avatar Nov 02 '15 18:11 rmcgibbo

the 2-clause bsd is compatible with the gpl http://www.gnu.org/licenses/license-list.en.html#ModifiedBSD

Cool, good to know. Thanks for the info!

drroe avatar Nov 02 '15 18:11 drroe

Note: this may be superseded by the TrajNG format eventually.

drroe avatar Apr 19 '16 01:04 drroe

so should we close this issue? or change to TNG?

hainm avatar Apr 19 '16 02:04 hainm

xtc will be around for a while

mpharrigan avatar Apr 19 '16 04:04 mpharrigan

so should we close this issue? or change to TNG?

No. It's just to remind me. It will probably make sense to open a separate issue for TrajNG eventually, but it's probably still higher priority to get XTC supported at the moment.

drroe avatar Apr 19 '16 16:04 drroe

What is TrajNG? Traj-Next-Gen?

swails avatar Apr 19 '16 16:04 swails

Yeah

hainm avatar Apr 19 '16 16:04 hainm

What is TrajNG? Traj-Next-Gen?

I think that's exactly it. See: http://redmine.gromacs.org/issues/1926#note-6

drroe avatar Apr 19 '16 16:04 drroe

Not sure why developers try to develop a bunch of file formats.

hainm avatar Apr 19 '16 16:04 hainm

http://link.springer.com/article/10.1007%2Fs00894-010-0948-5

hainm avatar Apr 19 '16 16:04 hainm

I really hate when "next-gen" makes it into the name of a product. It's an accurate descriptor for like 2 minutes.

swails avatar Apr 19 '16 17:04 swails

@hainm So they can have both good compression and good reading afterwards...

I'm happy to help get xtc and tng supported.

mabraham avatar Jun 24 '16 11:06 mabraham

@mabraham That would be great! I've started playing around with using libxdrfile under the hood for this but I think it would be good to have someone who is more familiar with the formats take a look at this.

drroe avatar Jun 24 '16 17:06 drroe

Changed title, XTC support added via #369.

drroe avatar Aug 01 '16 17:08 drroe

TNG addressed by #768.

drroe avatar Oct 18 '19 15:10 drroe

DTR added as of #796

drroe avatar Apr 06 '21 15:04 drroe