Amazinite

Results 241 comments of Amazinite

Events can only add or remove variants from fleets. They can not directly modify existing variants. (This is already the case.) But named variants can be modified by events. So...

Closing since I'm not actively working on getting this finished. Will reopen when I start to work on it again.

Nothing I can think of, although I often go over my own code every so often hunting for any potential errors or improvements and it's been a while since I've...

Spawned this fleet 100 times per test and checked which ships spawned and how many to see if it was working as intended. Only testing a normal fleet right now...

Looks like the issue was that the line `add variant 1` was being sent to Variant::Load, which was looking for a name at index 1, setting the name of the...

Testing this one now. ``` variant "test variant" "Shuttle" "Sparrow" "Star Barge" fleet "test fleet" government "Merchant" names "civilian" variant 3 variant "test variant" variant 1 Flivver ``` The tests...

Alright then. Anything else we could test that I might have missed?

@quyykk Want to give this a final review pass? I think I've squeezed everything out of this that I can at this point.

> As a side note, I think if you wanted to ship a subset of this PR Yeah, I've thought of doing that. So an appropriate subset would be making...