Amazinite

Results 241 comments of Amazinite

Closing all PRs which have been marked "orphaned."

If I am to implement the idea, I'll go with "division" or "squadron" or "flotilla" (single words used to describe a smaller formation of a naval fleet) to avoid confusion...

An alternative or addition to the `formation` idea might be to allow ships/variants in a variant to specify their weight and their size. e.g. This would send 2 Cruisers 25%...

Looks like as of right now, this is creating some errors. There are a lot of out of bounds traces. Notably, every out of bounds trace is for a fleet...

Looks like an error where I used `node` instead of `child` was causing all the issues, so this is mostly working as intended now. It looks like the number of...

Right now I've prevented a variant from containing itself directly, but I haven't prevented a loop of variants from being a thing. e.g. ``` variant "Testing 1" variant "Testing 2"...

Looks like the `1 + total weight` error was because I accidentally initialized the chosenShips of NestedChooseShips with all of the variant's ships, so ``` variant "Gunboat" "Rainmaker" ``` would...

Looks like certain fleet variants are crashing the game. 😎 Sit in Sol with the latest changes and you'll eventually crash. I got an error about memory being referred to...

All the necessary code changes (for functionality) should now be done (save for the update to the xCode file, and I should put more comments in the new files). If...

It hasn't been crashing for a while. (Almost a year now, actually.) As far as merging goes, I'm actually less confident about this than #4931. At least with that PR...