Amazinite
Amazinite
* Got to a number of the review comments with the latest commits, including replacing WeightedVariant with UnionItem. * Removed the ability for a named variant to be defined as...
Going back to a draft again since I broke another piece of this PR out into its own: #6835.
> This is, of course, assuming that generating a random number on a normal distribution using `normal_distribution` is comparable in cost to generating a random number on a uniform distribution...
So https://github.com/endless-sky/endless-sky/issues/5547 but not just in the UI?
The reason that SetReputationConditions and CheckReputationConditions existed is because in order for a ConditionSet to access information, that information had to be in the form of a Condition. Those two...
@petervdmeer If you play on an old save file, the older `"reputation: "` conditions are taking precedence over the reputationProvider. I used the World Forge missions that increase or decrease...
Should we be swapping the prefix match with the exact name match? https://github.com/endless-sky/endless-sky/blob/12f70efe38c3ac6e4127e8b586e6414b46ab8031/source/ConditionsStore.cpp#L450-L472 Or should we scrub the primary conditions of anything that matches a derived one, prefixed included?
While more improvements could perhaps be done, it looks like #7224 was sufficient for fixing this issue, so we can close this now.
> How does scanner power affect scan speed? > > For that matter, if we have a specific scan speed attribute, could we just simplify this to power only affecting...
Here's a linear equation if we wanted to change to that: ```c++ // 0.01 is sqrt(0.0001). We could technically leave the 0.0001 where it is now. // Taking distance squared...