sonar-stash icon indicating copy to clipboard operation
sonar-stash copied to clipboard

Report issues with no direct line in the diff view

Open t-8ch opened this issue 6 years ago • 9 comments

This may happen if the issue is reported on a line, that is not directly involved in the PR

Closes #135 #137

t-8ch avatar Nov 01 '17 14:11 t-8ch

Why isn't this in master yet :) ?

datasmurfen avatar May 16 '18 12:05 datasmurfen

Because none of the users confirmed, that this is what they want :-)

t-8ch avatar May 16 '18 12:05 t-8ch

Then I will confirm - that this would be nice :)

datasmurfen avatar May 16 '18 12:05 datasmurfen

Well, you should confirm that the implementation in this PR is sufficient.

t-8ch avatar May 16 '18 12:05 t-8ch

I read through the code, and it seems good 😄 The only comment I have is if it should be a setting, and not forced on all users - maybe? But not sure.

datasmurfen avatar May 16 '18 13:05 datasmurfen

Please confirm the implementation.

t-8ch avatar May 16 '18 13:05 t-8ch

I am sorry I don't understand - is there a button or so for that?
Or do you want me to writhe: I confirm the implementation :)

datasmurfen avatar May 16 '18 13:05 datasmurfen

No, you would have to get the source for this PR, build it, install it in sonarqube, run an analysis, see if it behaves as you expect and then possibly confirm the implementation.

t-8ch avatar May 16 '18 14:05 t-8ch

ping

snukone avatar Aug 07 '20 13:08 snukone