otter icon indicating copy to clipboard operation
otter copied to clipboard

[Bug]: Rules engine generators fail to import RulesEngineRunnerModule

Open cpaulve-1A opened this issue 9 months ago • 0 comments

Package name

rules-engine

Package version

10.0.3

Reproduction steps

  • Generate a workspace and an application using the @o3r/create generator
  • Add an application with npm run ng g @o3r/workspace:application test.
  • Run npm run ng add @o3r/rules-engine -- --project-name=test.
  • Generate a component using the npm run ng g component my-component command.
  • Convert the component into a rules-engine compatible component with the command npm run ng g rules-engine-to-component -- --path=apps/test/src/components/my-component.component.ts

Current result

The module RulesEngineRunnerModule is neither imported at app nor component level. image image

Expected result

The ng add script should add an import of the RulesEngineRunnerService module in the config.ts (or app.module.ts) in the application. This should not be a manual step.

In a similar fashion, the same module should be imported in the component's import list (in the module or the decorator of the module depending on whether the component is standalone or not) when running the npm run ng g rules-engine-to-component command.

Additional comments

No response

cpaulve-1A avatar May 15 '24 15:05 cpaulve-1A