otter icon indicating copy to clipboard operation
otter copied to clipboard

[Feature]: Less code when generating @o3r/workspace:application

Open ADR-Clizy opened this issue 10 months ago • 1 comments

Context

I generated a basic web app with o3r/workspace:application where I only need a router inside of it.

In the app.config I saw this

image

Which include a lot of complexity with Reducer / LocalStorage etc...

Also in dev additionnal module :

image

Proposal

Maybe we want to have a cleaner default app with only router.

I cleaned up everything and finish with this :

image image

In my point of view, it avoid to much complexity. As a beginner using this framework, it's more comfortable :)

ADR-Clizy avatar Apr 15 '24 13:04 ADR-Clizy

Thank you @ADR-Clizy for the proposal.

Let me translate your request in technical terms to facilitate the implementation:

  • The StorageSync should be setup in the application only on the add of @o3r/store-sync
  • The package @o3r/store-sync should be installed only if it is part of a preset
  • The load of EffectsModule, StoreModule and the runtimeCheck should be added to the application by the ng-add of a package depending on NgRx.
  • ⚠️ The package @o3r/application and the registration of the basic devtools modules should per default and still be added by the ng-add of @o3r/core

kpanot avatar Apr 16 '24 16:04 kpanot