otter icon indicating copy to clipboard operation
otter copied to clipboard

[Bug]: Reference to Digital and DES should be removed

Open vscaiceanu-1a opened this issue 1 year ago • 8 comments

Package name

all packages

Package version

9.5.0

Reproduction steps

Search for DES and Digital in the repository

Current result

image

Many references are still present

Expected result

References to Digital and DES should be removed

Additional comments

No response

vscaiceanu-1a avatar Jan 05 '24 14:01 vscaiceanu-1a

Hi @vscaiceanu-1a can i work on this issue? I have gone through the code, wanted to know if we remove the references to DES and Digital then will it not effect further paragraphs dependent on it. Like this one for instance. image

khardikk avatar Jan 08 '24 17:01 khardikk

Hi @khardikk ,

Sure you can you can work on the task. please do assign it to ourself before starting.

To reply to your question: it is depending of the link:

  • if the link is targetinbg DES/Digital documentation/application that is not already part of this repository (or https://github.com/AmadeusITGroup/ngx-prefetch/), it can be removed. (Up to the reviewer of the Pull Request do decide if the targeted document can be opened later on).
  • if the link is targeted old documentation as is now already part of this repository (the one targeted in your screenshot for example), this link need to be re-targeted (and link label can be also potentially be changed).

kpanot avatar Jan 09 '24 03:01 kpanot

Hi @khardikk ,

Sure you can you can work on the task. please do assign it to ourself before starting.

To reply to your question: it is depending of the link:

  • if the link is targetinbg DES/Digital documentation/application that is not already part of this repository (or https://github.com/AmadeusITGroup/ngx-prefetch/), it can be removed. (Up to the reviewer of the Pull Request do decide if the targeted document can be opened later on).
  • if the link is targeted old documentation as is now already part of this repository (the one targeted in your screenshot for example), this link need to be re-targeted (and link label can be also potentially be changed).

Hey @kpanot thanks for letting me work on this, wanted to ask, how can I assign it to myself as I don't have the permissions.

khardikk avatar Jan 10 '24 11:01 khardikk

@khardikk , My bad, I did not realize you need the permission for it. I have now assigned the issue to you.

kpanot avatar Jan 10 '24 12:01 kpanot

Hi @khardikk ,

Sure you can you can work on the task. please do assign it to ourself before starting.

To reply to your question: it is depending of the link:

  • if the link is targetinbg DES/Digital documentation/application that is not already part of this repository (or https://github.com/AmadeusITGroup/ngx-prefetch/), it can be removed. (Up to the reviewer of the Pull Request do decide if the targeted document can be opened later on).
  • if the link is targeted old documentation as is now already part of this repository (the one targeted in your screenshot for example), this link need to be re-targeted (and link label can be also potentially be changed).

Hi @kpanot as you mentioned, the links that are already part of this repo, need to be re-targeted, where do they need to be re-targeted exactly?

khardikk avatar Jan 14 '24 19:01 khardikk

Hi @khardikk , If a link is targeting a document that does not exist (or part of an non-accessible repository) but a documentation matching matching the link is present in this repository, then the URL of the link need to be changed to target this matching documentation.

kpanot avatar Jan 16 '24 04:01 kpanot

hi @khardikk Don't worry that much about the links, it Will be fixed in https://github.com/AmadeusITGroup/otter/pull/1267

vscaiceanu-1a avatar Jan 24 '24 16:01 vscaiceanu-1a

hi @khardikk Don't worry that much about the links, it Will be fixed in https://github.com/AmadeusITGroup/otter/pull/1267

Alright thanks for letting me know

khardikk avatar Jan 24 '24 17:01 khardikk