gothic-1-community-patch icon indicating copy to clipboard operation
gothic-1-community-patch copied to clipboard

Baal Cadar: Dialogue option for learning Magic Circles is missing LP cost (DE/EN)

Open m0ezes opened this issue 5 months ago • 0 comments

Please agree to the following

Describe the bug

The dialogue option for learning a new magic circle from Guru Baal Cadar in the Swamp Camp is missing the respective LP cost.

Expected behavior

Die Gesprächsoptionen zum Erlernen der magischen Kreise bei Baal Cadar zeigen nun korrekt die jeweils benötigten Lernpunkte an.

Beispiel: 1. Kreis der Magie (10 Lernpunkte)

Steps to reproduce the issue

  1. Join the Swamp Camp.
  2. Go to Baal Cadar.
  3. Make sure to get the guru's attention (cast a sleep spell on one of his students) if you haven't already.
  4. Talk to Baal Cadar and choose "Lehre mich die Magie der Runen.".
  5. After that, you have the dialogue option(s) available.

Additional context

The main problem here is that the player isn't aware that he is spending LP when selecting this dialogue option, nor does he know how much he' spending. In case the player can't afford a magic circle, the game tells the player that he is missing LP but it still doesn't say how much LP are missing.

I've compared DIA_GUR_1208_BaalCadar.d with DIA_KDF_402_Corristo.d and DIA_KDW_600_Saturas.d and noticed that the scripts for Corristo and Saturas are using B_BuildLearnString(NAME_LearnMage_n, LPCOST_TALENT_MAGE_n, 0) to display a proper string with all needed information while the Cadar script simply transcribes the audio file and handles this like a "normal" line of dialogue.

Looking at the files in the English scriptbase, I think the same problem exists in the English localization of the game:

  • I am ready to enter the First Circle. instead of 1st Circle of Magic (10 skill points)

This bug is very similar (or technically the same) to issue #340, which is about a missing B_BuildBuyArmorString function. It almost seems like this is a Baal-exclusive problem. Because as far as I can tell from looking at the scripts, all dialogue strings in the game for buying armor/talents (meaning the final option you choose to confirm your investment) are created through B_Build[...] - except these two in the Swamp Camp.

Screenshot: Dialogue option for learning the 2nd circle without LP cost displayed (German language) GOTHIC 1 08k_mod 10 09 2024 05_58_15

m0ezes avatar Sep 10 '24 22:09 m0ezes