gothic-1-community-patch icon indicating copy to clipboard operation
gothic-1-community-patch copied to clipboard

Spelling - "Quotation Marks" typo in PC subtitle.

Open Quintus24 opened this issue 2 years ago • 4 comments

Hello, everyone!

I would like to report the following bug:

Describe the bug: This issue can be encountered after the user joins the Swamp Camp and speaks with NPC "Cor Kalom". The Player Character has the option to inquire about a "welcome" upon completing the quest and the following subtitle string will be displayed: "That was it? No ""welcome"", no nothing?" There are a few too many quotation marks in that string.

Expected behavior: The subtitle string is correctly displayed as: That was it? No "welcome", no nothing?

Steps to reproduce the issue:

  1. Initiate and complete the "Admission to the Swamp Camp" quest.
  2. Talk with NPC "Cor Kalom" and select the "That was it? No welcome, no nothing?" option.
  3. Notice the subtitle string spoken by the Player Character.

Additional context I don't know for certain if quotation marks are also required for the "welcome" within the string in the dialogue box.

Attaching screenshots for more clear information.

  1. Join the Swamp Camp. Initiate Conversation

  2. "Welcome" dialogue option. Dialogue Option

  3. "Quotation Marks" issue. Quotation Marks

Thank You and Best Regards! Quintus24

Quintus24 avatar Apr 24 '22 20:04 Quintus24

https://github.com/AmProsius/gothic-1-community-patch/blob/79e466cd6da87113b3144cb4bcf31d3ca19726eb/scriptbase/_work/Data/Scripts/Content/Story/Missions/DIA_GUR_1201_CorKalom.d#L351-L357

changed to

func void  GUR_1201_CorKalom_JoinPSI2_Info()
{
    AI_Output           (other, self,"GUR_1201_CorKalom_JoinPSI_15_10"); //That was it? No welcome, no nothing?
    AI_Output           (self, other,"GUR_1201_CorKalom_JoinPSI_10_11"); //Welcome.
    AI_Output           (other, self,"GUR_1201_CorKalom_JoinPSI_15_12"); //Sounds much better.
    AI_Output           (self, other,"GUR_1201_CorKalom_JoinPSI_10_13"); //Don't hang around here! Do something. Take these weeds and give them to Gomez in the Old Camp.
    AI_Output           (self, other,"GUR_1201_CorKalom_JoinPSI_10_14"); //If his henchmen don't let you pass, tell them Cor Kalom sent you.

AmProsius avatar Apr 25 '22 19:04 AmProsius

@AmProsius why not remove the quotation marks around the sentence entirely?

szapp avatar Apr 26 '22 15:04 szapp

@AmProsius why not remove the quotation marks around the sentence entirely?

Right, thanks!

AmProsius avatar Apr 26 '22 16:04 AmProsius

We might even be able to correct the quotation marks (to That was it? No "welcome", no nothing?) instead of completely removing them all together. However, then it would not match the dialog description (what the player selects in the dialog box): https://github.com/AmProsius/gothic-1-community-patch/blob/79e466cd6da87113b3144cb4bcf31d3ca19726eb/scriptbase/_work/Data/Scripts/Content/Story/Missions/DIA_GUR_1201_CorKalom.d#L340

szapp avatar May 06 '22 06:05 szapp