gothic-1-community-patch icon indicating copy to clipboard operation
gothic-1-community-patch copied to clipboard

YBerion give us extra reward if we became SwampCamp Guard (destinated only for non members of Swamp Camp)

Open pawbuj1981 opened this issue 3 years ago • 2 comments

Hi ! I found a bug, when we became a SwampCamp Guard (GIL_TPL) we can get amulet as a reward from YBerrion for killing Minecrawler Queen. YBerrion said the reward is only for the people from out of the Brotherhood community.

There is one condition missing in the vanilla code reffering to GIL_TPL.

How to reproduce this bug? After killing MincecralwerQueen just first go to talk to Cor Angar and decide to be a guard. A then go to YBerrion for reward...

Here is the code as it should be:

`if ( YBerion_BringFocus == LOG_SUCCESS) && ( Npc_GetTrueGuild (hero)!= GIL_NOV ) && ( C_IsChapter(2)

&& ( Npc_GetTrueGuild (hero)!= GIL_TPL ) )//this part added `

pawbuj1981 avatar Jan 27 '22 13:01 pawbuj1981

An alternative approach could be to replace Npc_GetTrueGuild (hero)!= GIL_NOV with C_NpcBelongsToPsiCamp(hero), but since it's easier to add the above condition, let's stick with that:

https://github.com/AmProsius/gothic-1-community-patch/blob/39e050914ae56e2cc0d6c63a3f3bb204dfa34372/scriptbase/_work/Data/Scripts/Content/Story/Missions/DIA_GUR_1200_YBerion.d#L257-L264

changed to

FUNC int  GUR_1200_Yberion_EARN_Condition()
{
    if ( YBerion_BringFocus == LOG_SUCCESS)
    && ( Npc_GetTrueGuild (hero)!= GIL_NOV )
    && ( Npc_GetTrueGuild (hero)!= GIL_TPL )
    && ( C_IsChapter(2) )
    {
        return 1;
    };

};

AmProsius avatar Jan 27 '22 20:01 AmProsius

Similar to #17/#65.

AmProsius avatar Jan 27 '22 20:01 AmProsius