gothic-1-community-patch icon indicating copy to clipboard operation
gothic-1-community-patch copied to clipboard
verified publisher icon AmProsius

The "BACK" string is above the dialogue string.

Open Quintus24 opened this issue 3 years ago • 1 comments

Hello, everyone!

I would like to report the following bug:

Describe the bug: The issue can be encountered at Cavalorn's Hut if the user talks with the NPC "Scorpio". The "BACK" string is above the "Crossbow Level 1 (200 ore, 10 skill points)" string.

Expected behavior: The "BACK" option will always be at the bottom of the dialogue box.

Steps to reproduce the issue:

  1. Travel to Cavalorn's Hut at the OW_CAVALORN_01 waypoint.
  2. Talk with NPC "Scorpio" and select the "Will you train me?" dialogue option.
  3. Notice the "BACK" string is above the "Crossbow Level 1 (200 ore, 10 skill points)" string.

Additional context Issue encountered in Chapter 4.

Attaching screenshots for more clear information.

  1. Initiate conversation. Dialogue Training

  2. Dialogue box. BACK String

  3. Location at OW_CAVALORN_01 waypoint. Location @ OW_CAVALORN_01

Thank You and Best Regards! Quintus24

Quintus24 avatar Jan 04 '22 19:01 Quintus24

Thanks for reporting.

Background

Choices are listed in reverse order that they are added. In the mentioned dialog, the "back" choice is added last.

Fix

https://github.com/AmProsius/gothic-1-community-patch/blob/b946ba1189a6937510bfbfaeff64a2df55d9cccb/scriptbase/_work/Data/Scripts/Content/Story/Missions/DIA_GRD_205_Scorpio.d#L201-L203

changed to

    Info_ClearChoices (GRD_205_Scorpio_CROSSBOW);
    Info_Addchoice  (GRD_205_Scorpio_CROSSBOW,DIALOG_BACK,GRD_205_Scorpio_CROSSBOW_BACK);
    Info_Addchoice  (GRD_205_Scorpio_CROSSBOW,B_BuildLearnString(NAME_LearnCrossbow_1,  LPCOST_TALENT_CROSSBOW_1,200),GRD_205_Scorpio_CROSSBOW_OK);

Diff:

      Info_ClearChoices (GRD_205_Scorpio_CROSSBOW);
+     Info_Addchoice  (GRD_205_Scorpio_CROSSBOW,DIALOG_BACK,GRD_205_Scorpio_CROSSBOW_BACK);
      Info_Addchoice  (GRD_205_Scorpio_CROSSBOW,B_BuildLearnString(NAME_LearnCrossbow_1,  LPCOST_TALENT_CROSSBOW_1,200),GRD_205_Scorpio_CROSSBOW_OK);
-     Info_Addchoice  (GRD_205_Scorpio_CROSSBOW,DIALOG_BACK,GRD_205_Scorpio_CROSSBOW_BACK);

Related

There is no other dialog in the original game with the same issue, except for one: https://github.com/AmProsius/gothic-1-community-patch/blob/b946ba1189a6937510bfbfaeff64a2df55d9cccb/scriptbase/_work/Data/Scripts/Content/Story/Missions/DIA_GRD_205_Scorpio.d#L260-L262

szapp avatar Jan 05 '22 10:01 szapp