gothic-1-community-patch icon indicating copy to clipboard operation
gothic-1-community-patch copied to clipboard

Published 20 hours ago • verified publisher icon AmProsius

The "END" string is above the dialogue string.

Open Quintus24 opened this issue 3 years ago • 1 comments

Hello, everyone!

I would like to report the following bug:

Describe the bug: The issue can be encountered in the Old Mine if the user talks with the NPC "Garp". The "END" string is above the "What's the Orc doing here?" string.

Expected behavior: The "END" option will always be at the bottom of the dialogue box.

Steps to reproduce the issue

  1. Travel to the Old Mine and enter it.
  2. Reach the OM_PICKORE_11 waypoint and speak with NPC "Garp".
  3. Notice the "END" string is above the "What's the Orc doing here?" string.

Additional context Minor issue due to the fact that the "What's the Orc doing here?" string will disappear once used.

Attaching screenshots for more clear information.

  1. Dialogue Box. Garp Dialogue Box

  2. NPC "Garp" location at OM_PICKORE_11 waypoint. Garp Location @ OM_PICKORE_11

Thank You and Best Regards! Quintus24

Quintus24 avatar Dec 22 '21 02:12 Quintus24

Good find!

Some technical background, plus fix suggestion @AmProsius:

Every dialog instance has a number that is responsible for the ordering in the dialog options. The end dialog for every NPC has always the number 999 (there are some exceptions for complicated dialogs), meaning the end option is always at the bottom. The NPC Garp (Vlk_587_Garp) has only two dialog options, see relevant scripts below. For both of them the numbering was seemingly forgotten. Since they are not specified in the dialog instance, they default to zero. This makes their ordering (semi) ambiguous.

The easiest solution is just to set the number of the end dialog to 999, but leave the other (and possibly further mod-dialog options) untouched. This can be implemented similar to how we change the permanent property of dialogs, see the PR #108 (fixing the issue #30):

In session fix,

  • check if the dialog instance Vlk_587_Garp_Exit exists
  • check if its nr property is 0
  • set it to 999

The test will most likely have to be manual.

Relevant code portion https://github.com/AmProsius/gothic-1-community-patch/blob/2892a60a3edf33340d7907fe7b3c137d079e8474/scriptbase/_work/Data/Scripts/Content/Story/Missions/DIA_VLK_587_Garp.d#L2-L22

szapp avatar Dec 22 '21 10:12 szapp