gothic-1-community-patch icon indicating copy to clipboard operation
gothic-1-community-patch copied to clipboard

The "Title Deed" item has a "Value" string issue.

Open Quintus24 opened this issue 4 years ago • 6 comments

Hello, everyone!

I would like to report the following bug:

Describe the bug: The issue can be encountered in the "Mountain Fortress" when the user acquires the "Title Deed" item. The "Value" of the item is displayed as "400 pounds of".

Expected behavior: The item's "Value" is displayed as "400 pounds of gold", or "400 pounds of coins" or "15 Ore". (speculation)

Steps to reproduce the issue:

  1. Travel to the "Mountain Fortress" and climb to the first floor.
  2. Locate the Chest on the balcony and interact with it. (make sure you have the key for it)
  3. Loot the "Title Deed" item and notice its "Value".

Additional context The certificate does state that the selling of the fort goes "for 400 units of gold.". If the user attempts to sell the item to any merchant, the selling price will be "8 Ore". If the item is sold, it can be purchased back for "15 Ore".

Opinion: To be honest, I'm not 100% sure if this is a bug or it's simply missing a word, nonetheless, the "Value" is a bit confusing. Maybe the "400 pounds of" text is indeed the intended one, it gives it a more medieval and elegant style of writing. I did encounter this while still playing in "Chapter 1", not sure if relevant. I was also curios if it can be sold to a merchant, that's how I noticed the actual ore value.

I have attached multiple screenshots for more clear information.

  1. The "Title Deed" item with its "Value". Title Deed Bug

  2. The text within the document. Certificate Text

  3. Selling the document for "8 Ore". Selling for 8 Ore

  4. Buying the document for "15 Ore". Buying for 15 Ore

Thank You and Best Regards! Quintus24

Quintus24 avatar Dec 09 '21 03:12 Quintus24

Thanks for reporting! This is not actually a script bug as the "value" is correct: https://github.com/AmProsius/gothic-1-community-patch/blob/b946ba1189a6937510bfbfaeff64a2df55d9cccb/scriptbase/_work/Data/Scripts/Content/Items/MissionItems_3.d#L216-L235

However for low resolutions it seems to be an issue. Do you use the Systempack/Union?

AmProsius avatar Dec 09 '21 10:12 AmProsius

However for low resolutions it seems to be an issue. Do you use the Systempack/Union?

Hi, @AmProsius, I use the Steam version, but it does have the Systempack incorporated and active. I also checked my game resolution, it is set as 1366x768x32. Unfortunately, I play this game on a Laptop.

Regards, Quintus24

Quintus24 avatar Dec 09 '21 14:12 Quintus24

We could try to remove some whitespaces, but there might be a better approach.

AmProsius avatar Dec 09 '21 16:12 AmProsius

Related to #242. A fix, although separate, may be implemented similarly:

Checking the display length of a string with Print_GetStringWidth and the width of the parent view. For #242, the parent view could then be enlarged. Here, on the other hand, the string could be adjusted by removing sufficiently enough spaces.

szapp avatar Dec 17 '21 11:12 szapp

Checking the display length of a string with Print_GetStringWidth and the width of the parent view. For #242, the parent view could then be enlarged. Here, on the other hand, the string could be adjusted by removing sufficiently enough spaces.

And if the container cannot be enlarged, the text can at least be truncated properly.

AmProsius avatar Dec 17 '21 12:12 AmProsius

I wonder if there may be an easy way for a line break (in the case of dialog choice boxes).

szapp avatar Dec 17 '21 13:12 szapp