gothic-1-community-patch icon indicating copy to clipboard operation
gothic-1-community-patch copied to clipboard

Wrong voice for dialog option with Lee

Open AmProsius opened this issue 3 years ago • 2 comments

Describe the bug The player character's voice is swapped with Lee's voice when buying a medium mercenary armor from him.

Expected behavior The player character's voice is now correct when buying a medium mercenary armor from him.

Additional context Bug provided by Blubbler. Since we don't want to add new sound files, we rely on replacing the faulty ones with existing ones that make sense.

AmProsius avatar Oct 11 '21 07:10 AmProsius

https://github.com/AmProsius/gothic-1-community-patch/blob/3db5d668ca0b2d209cd32f5697c969db05a239f0/scriptbase/_work/Data/Scripts/Content/Story/Missions/DIA_SLD_700_Lee.d#L432

changed to

    AI_Output               (other, self,"DIA_Wolf_SellArmor_M_15_01"); //I want medium armor.

AmProsius avatar Oct 11 '21 11:10 AmProsius

The proposed fix requires to change the output unit that is triggered within the function Sld_700_Lee_ARMOR_M.

That will necessitate to create a function similar to G1CP_ReplaceOuInst. However, I see a bit of a naming conflict with the recent functions G1CP_ReplaceOuText and G1CP_ReplaceOuFilename. The latter ones modify the actual output unit, the former one changes the call to an output unit.

szapp avatar Jan 18 '22 10:01 szapp