AmPhIbIaN26

Results 37 comments of AmPhIbIaN26

> I still didn't understand how the user would use this `[system for system in NUMERAL_SYSTEMS if system != 'roman']` Let’s say we introduce a `numeral_systems` parameter to `parse_number` so...

Hi @Gallaecio hope you and your family are safe. I added the ```_valid_input_by_numeral_system()``` ([in this fork](https://github.com/AmPhIbIaN26/number-parser/tree/parse_roman(numeral-support))) still have to improve this so it is easier to add another numeral system....

I have added `numeral_systems` as a parameter to `parse()`, the current system works like this ```python all_numeral_systems_but_roman = [system for system in NUMERAL_SYSTEMS if system != 'roman'] all_numeral_systems_but_decimal = [system...

Thanks for looking into these, ill make the changes

@Gallaecio hope you and your family are safe. I have made all the changes you suggested also added support for incorrect roman numbers.

Hi @Gallaecio hope you and your family are safe. Any thoughts on this?

Hi @Gallaecio hope you and your family are safe. I looked and did not find any other open calls without encoding, also added Windows to the CI. I wanted to...