Alwin Esch
Alwin Esch
Checked on web about `ICU4C` seems available for all OS then no `PLATFORM_OPTIONAL_DEPS` required. Only to add a `FindICU4C.cmake`, maybe try as this (not tested): ```cmake #.rst: # FindICU4C #...
@djp952 can you do an rebase that we can bring in this weekend.
Have created requests on all PVR add-ons. Only with version increase, no code changes.
> @AlwinEsch build failed due to new warning (=> quality gate missed): > > https://jenkins.kodi.tv/job/Android-X86/17294/clang/source.24c3e16e-f448-41ec-8b5a-66b188a74fb2/#32 Should @howie-f do a change about or to bring in as this or to make...
> I've made some formatting changes to meet the current code style. The diffs are available in the following links: > > * [PR21739-0003-6ae59dbe2d-addons-clang-style-cleanup-on-Addo.diff](https://jenkins.kodi.tv/job/BuildMulti-PR/23515/artifact/PR21739-0003-6ae59dbe2d-addons-clang-style-cleanup-on-Addo.diff) > * [PR21739.diff](https://jenkins.kodi.tv/job/BuildMulti-PR/23515/artifact/PR21739.diff) > > For...
> Can you add documentation about what "unique work ID" means in the code? Have added on one commit, looks maybe a bit big, but was not come with my...
Is rebased, if nothing against I bring in later to cleanup the other request.
> I was wondering if it would make more sense to introduce a `CAddonInstance` class which holds the settings of a specific instance to avoid having to add the `instance`...
Maybe easier possible to manage, if mostly only `CAddonInfo` becomes used and CAddon only on related processes where does his own works.