Ngrok-LAN icon indicating copy to clipboard operation
Ngrok-LAN copied to clipboard

[INCOMPATIBILITY] Custom LAN

Open Sirmentio opened this issue 1 year ago • 6 comments

Name of Mod Custom LAN

Link to Mod Source https://github.com/DimiDimit/Custom-LAN

Screenshots N/A

Desktop (please complete the following information):

  • OS: Windows 11
  • Minecraft Version 1.19.3
  • Ngrok-LAN Version 1.4.4

Additional context

  • Crash happens the moment you click "Open to LAN"
  • Crash log: https://mclo.gs/cgXUeVy

Sirmentio avatar Feb 20 '23 20:02 Sirmentio

I can see this being fixable, but I'm not exactly sure how.

This might take some time to fix because I'm a little busy at the moment and Custom LAN entirely overhauls how LAN worlds work.

Our mod just takes the Vanilla way and tunnels it with ngrok. I would have to define different behaviour when Custom LAN is being used. This will take some time to figure out how to make them compatible.

Flooflez avatar Feb 20 '23 20:02 Flooflez

please do, custom LAN is the only way I can use simple voice chat without buying a server

slovinsqui avatar Jun 20 '23 04:06 slovinsqui

Seeing as this mod reimplements a lot of Custom LAN's features, it'll probably be easier to just add ngrok support to Custom LAN…

For the time being, you could use the CLI (replace 25565 with your port):

ngrok tcp 25565

See also https://github.com/DimiDimit/Custom-LAN/issues/28.

DimiDimit avatar Oct 15 '23 19:10 DimiDimit

@DimiDimit You totally can go ahead if you wish, I don't really have the time to work on this project these days.

Here's the wrapper we're using, it's pretty simple to use. You can use this project for reference if needed/

Flooflez avatar Oct 15 '23 19:10 Flooflez

ngrok support has been added in Custom LAN 2.3.0, using the new Tunnel button on the Open to LAN screen! As a bonus, you can start and stop the tunnel without restarting the LAN server and kicking all players out.

DimiDimit avatar Oct 17 '23 00:10 DimiDimit

@DimiDimit cool man, I've added a won'tfix tag to this

Flooflez avatar Oct 17 '23 00:10 Flooflez