gatekeeper icon indicating copy to clipboard operation
gatekeeper copied to clipboard

GSOC 2018: Implementing blackholing in Gatekeeper

Open gogapp opened this issue 6 years ago • 5 comments

This PR implements space saving algorithm in Gatekeeper.

gogapp avatar Jun 17 '18 17:06 gogapp

Hi mentors,

I have added the changes that you have requested. I have also merged the commits into a single meaningful commit.

Please note that the implementation is still not fully complete and I am working on the TODOs present in the code.

gogapp avatar Jun 25 '18 15:06 gogapp

I have added the code files for the final review and fixed the styling errors. For testing of the algorithms, I have created a different repository here. https://github.com/gogapp/GSOC-2018-tests

gogapp avatar Aug 14 '18 15:08 gogapp

Can you rebase your code to include one commit to add the space saving algorithm and one commit to add the RHHH algorithm? In other words, we shouldn't have a separate commit for fixing the style issues.

Also, the Gatekeeper code does not call the functions you are adding. To merge these changes we will need to have it actually integrated with Gatekeeper.

cjdoucette avatar Sep 26 '18 16:09 cjdoucette

I have rebased the commits as requested.

To get the changes integrated with Gatekeeper, I need to think out ways to do this. Currently I am focusing on my College Placements. I will integrate the functions with Gatekeeper as soon as I am free.

gogapp avatar Sep 27 '18 08:09 gogapp

Suggestion for where to integrate: gt_proc() at if (pkt_info.priority <= 1) {. That is, you'd feed all packets that are in accepted flows to the algorithms you implemented.

AltraMayor avatar Sep 27 '18 12:09 AltraMayor