gatekeeper icon indicating copy to clipboard operation
gatekeeper copied to clipboard

Published 20 hours ago • verified publisher icon AltraMayor

Merge our DPDK patches upstream

Open AltraMayor opened this issue 7 years ago • 3 comments

We have a number of small patches to DPDK in https://github.com/cjdoucette/dpdk that Gatekeeper relies on. We should get these patches merged upstream, so Gatekeeper can use the latest version of DPDK.

AltraMayor avatar Aug 22 '17 14:08 AltraMayor

rte_strdup() in main/main.c is a small, useful function that should go upstream as well. It's being used in a number of places in Gatekeeper.

AltraMayor avatar Dec 27 '18 07:12 AltraMayor

Note that our rte_strdup() will return NULL when the source string is NULL, so we must check that is the expected behavior of strdup(3) before pushing the patch upstream. If that's not the behavior of strdup(3), we must fix our version and patch the Gatekeeper accordingly. Finally, rte_strdup() needs to update errno when not enough memory is available.

AltraMayor avatar Jan 02 '19 13:01 AltraMayor

One should search the code of Gatekeeper to identify all small functions that should be pushed upstream. For example: rte_priv_to_mbuf() and rte_mbuf_prefetch_part2_non_temporal().

AltraMayor avatar Nov 18 '19 14:11 AltraMayor