f3
f3 copied to clipboard
AltraMayor
Add f3write --keep and f3read --delete parameters
Hi @brianpow,
Before we go through code review, could you describe the use case that this pull request intends to help? It doesn't need to be formal or long, I'm just looking for a brief description of the situation in which someone would want to use the parameter --keep. I understood what the parameter does, but I couldn't come up with a situation that I'd use it.
Thank you.
Hi @brianpow,
Before we go through code review, could you describe the use case that this pull request intends to help? It doesn't need to be formal or long, I'm just looking for a brief description of the situation in which someone would want to use the parameter
--keep. I understood what the parameter does, but I couldn't come up with a situation that I'd use it.Thank you.
Hi. If the flash memory is overheated, your computer is suspended or the test is interrupted accidentally, we can keep the existing files and continue f3write instead of creating everything from beginning.
now f3read can delete corrupted NUM.h2w. It makes my life easier if corrupted file was found and I want to tested again by recreating only those corrupted file. So I can easily run these command without counting around the start or end number.
f3read -d /dev/XXX ; f3write -k /dev/XXX; f3read /dev/XXX
for f3probe, with --fix parameter, again user doesn't need to mark down the sectors and run f3fix.
Both changes are good for unattended test/fix too
Having f3read --delete does add meaning to f3write --keep. I'm going to work with you to review the code and merge it.
Let's start making this pull request coherent. First, create a second pull request and move patch add --fix parameter to run f3fix automatically if counterfeit memory detected. I intend to accept this second pull request as well, but let's get a thing done at a time.
Please add f3read: , f3write: , f3probe: to the title of the patches accordingly. You can find examples in the log of the repository.
@AltraMayor Thank you for your comments and guidance. Sorry that I just started a big project. For those glitches, I guess majorities of them won't break the program and hope someone will fix them. Sorry again for my poor programming habit.
I'm going to leave this pull request open, so someone else can pick it up if the need for it comes. Good luck on your new project!