altinn-studio icon indicating copy to clipboard operation
altinn-studio copied to clipboard

use correct property for app created by in about page

Open nkylstad opened this issue 1 year ago • 1 comments

Description

Use createdBy from applicationMetadata rather than the author of initial commit, because we support copying apps, and it is the createdBy author that is relevant here.

Related Issue(s)

  • #6707

Verification

  • [x] Your code builds clean without any errors or warnings
  • [x] Manual testing done (required)
  • [ ] Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • [ ] User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

nkylstad avatar May 07 '24 13:05 nkylstad

Codecov Report

Attention: Patch coverage is 85.71429% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 90.24%. Comparing base (da69059) to head (3757754). Report is 8 commits behind head on main.

Files Patch % Lines
...features/overview/handleServiceInformationSagas.ts 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12782      +/-   ##
==========================================
+ Coverage   90.19%   90.24%   +0.04%     
==========================================
  Files        1308     1307       -1     
  Lines       18760    18733      -27     
  Branches     2281     2281              
==========================================
- Hits        16921    16906      -15     
+ Misses       1579     1567      -12     
  Partials      260      260              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 07 '24 13:05 codecov[bot]

Can we delete useGetRepoInitialCommit hook and all code related to it? Since it looks like it was only used for this purpose. I can understand the potential need to keep it in backend since it is sort of a wrapper api

Yep, good input! I cleaned up the initialCommit state in the redux-code as well, seems like that was not being used at all.

nkylstad avatar May 13 '24 11:05 nkylstad