altinn-studio icon indicating copy to clipboard operation
altinn-studio copied to clipboard

Centralize routes to avoid duplicating them

Open mlqn opened this issue 10 months ago • 0 comments

Description

We might consider extracting / centralizing routes as constants (e.g. shared/src/constants.js or shared/src/routes.js or shared/src/dashboard-routes.js, ...) as we did for DASHBOARD_ROOT_ROUTE to avoid duplicating them.

Here are examples of duplicated strings for the /contact route :

https://github.com/Altinn/altinn-studio/blob/cd168f205b868c3d63c32711e84e2337af5a71fd/frontend/studio-root/app/App.tsx#L17

https://github.com/Altinn/altinn-studio/blob/cd168f205b868c3d63c32711e84e2337af5a71fd/frontend/packages/shared/src/components/ErrorBoundaryFallback.tsx#L23

https://github.com/Altinn/altinn-studio/blob/cd168f205b868c3d63c32711e84e2337af5a71fd/frontend/app-development/features/overview/components/Overview.tsx#L40

https://github.com/Altinn/altinn-studio/blob/cd168f205b868c3d63c32711e84e2337af5a71fd/frontend/app-development/features/overview/components/RepoOwnedByPersonInfo.tsx#L17

https://github.com/Altinn/altinn-studio/blob/cd168f205b868c3d63c32711e84e2337af5a71fd/frontend/app-development/features/appPublish/components/Deploy.tsx#L78

https://github.com/Altinn/altinn-studio/blob/cd168f205b868c3d63c32711e84e2337af5a71fd/frontend/packages/shared/src/contexts/ServicesContext.tsx#L75

Additional Information

No response

Tasks

No response

Acceptance Criterias

No response

mlqn avatar Apr 05 '24 10:04 mlqn