altinn-studio icon indicating copy to clipboard operation
altinn-studio copied to clipboard

Dragging a task increases the counter for unsaved changes

Open mlqn opened this issue 1 year ago • 4 comments

Description of the bug

Dragging a task in the process palette without adding it counts as 1 unsaved change, and drag dropping it counts as 2 unsaved changes

Steps To Reproduce

https://github.com/Altinn/altinn-studio/assets/24462611/f0fcf448-80a2-42dd-81a2-01bd78766ef7

Additional Information

No response

mlqn avatar Jan 03 '24 16:01 mlqn

Perhaps as a way of simplifying this a little, we could just show "You have unsaved changes" without the counter if counter > 0? Thoughts @Annikenkbrathen @framitdavid ?

nkylstad avatar Mar 15 '24 12:03 nkylstad

Perhaps as a way of simplifying this a little, we could just show "You have unsaved changes" without the counter if counter > 0? Thoughts @Annikenkbrathen @framitdavid ?

Certainly! I agree with that solution for two main reasons. Firstly, it simplifies the code implementation by avoiding the need to filter what should be counted as a change or not. Secondly, I don't believe the number of changes is relevant to the user. I think the user only cares about whether they need to save or not.

Note: Regarding saving; should we consider implementing a debounced save to eliminate the need for the save button and number of changes text altogether? 🤔We are only saving to the local files, and then the behaviour with "Slett mine lokale endringer" will be consistent.

framitdavid avatar Mar 15 '24 13:03 framitdavid

Completely agree that this is a good solution. I've also thought about "Slett mine endringer " if perhaps there should be a button next to save like "discard" or "cancel." There should be an easy action to quit editing In case the user just wants to experiment a bit and regret it later. Skjermbilde 2024-03-19 kl  11 11 27

Annikenkbrathen avatar Mar 19 '24 10:03 Annikenkbrathen

As we are moving towards autosaving, the issues is moved to blocked until we are happy with the implementation of the autosaving.

WilliamThorenfeldt avatar Apr 04 '24 08:04 WilliamThorenfeldt

Closing this issue now as it is covered by autosave.

nkylstad avatar Apr 08 '24 07:04 nkylstad