clickhouse-sink-connector icon indicating copy to clipboard operation
clickhouse-sink-connector copied to clipboard

Published 20 hours ago • verified publisher icon Altinity

Fix the getVersionColumnForReplacingMergeTree() to support replicated tables properly

Open IlyaTsoi opened this issue 1 year ago • 1 comments

  1. In the current logic the getVersionColumnForReplacingMergeTree() returns only version_column from a replicated table definition (here versionColumn = parameterArray[2].trim();), but a is_deleted column migth be there too.

  2. It's unnecessary to have separate if clauses for replicated and nonreplicated tables, we can union them.

IlyaTsoi avatar Oct 25 '23 11:10 IlyaTsoi

Please check DBMetadataTest and add your new SQL that you are trying to fix.

subkanthi avatar Oct 25 '23 15:10 subkanthi