Enable default user to use secret
Signed-off-by: Suzy Wang [email protected]
Thanks for taking the time to contribute to clickhouse-operator!
Please, read carefully instructions on how to make a Pull Request.
This will help a lot for maintainers to adopt your Pull Request.
Important items to consider before making a Pull Request
Please check items PR complies to:
- [x] All commits in the PR are squashed. More info
- [x] The PR is made into dedicated
next-releasebranch, not intomasterbranch1. More info - [x] The PR is signed. More info
--
1 If you feel your PR does not affect any Go-code or any testable functionality (for example, PR contains docs only or supplementary materials), PR can be made into master branch, but it has to be confirmed by project's maintainer.
@SuzyWangIBMer , I do not think it is a good idea to use a global secret for default user in all installations. Do you know, that you can specify secret for any user in CHI already? The syntax is the following:
configuration:
users:
user1/k8s_secret_password: test/test-011-secret/pwduser1
user2/k8s_secret_password_sha256_hex: test/test-011-secret/pwduser2
user3/k8s_secret_password_double_sha1_hex: test/test-011-secret/pwduser3
However, for default it is not going to work properly if you are using sharded cluster, since inter-cluster configuration needs to be updated as well. We are working on a proper support in 0.20.0
Hi @alex-zaitsev , the purpose of this pr is to support default user to use secret the same way that any customized users are already supported in operator. It is our initial question that why default user is different. Are you going to keep default user in a different section for the future?
Not needed anymore, since secrets are supported for all users now.