altinity-dashboard icon indicating copy to clipboard operation
altinity-dashboard copied to clipboard

ListSelector has workaround for Patternfly bug

Open ghjm opened this issue 3 years ago • 0 comments

The ListSelector has a workaround here: https://github.com/Altinity/altinity-dashboard/blob/main/ui/src/app/Components/ListSelector.tsx#L17 for a bug in Patternfly where the ContextSelector does not open on first click when menuAppend is set to document.body, tracked here: https://github.com/patternfly/patternfly-react/issues/6824. After the upstream issue closes, we should remove the workaround.

As an alternative, we could implement ListSelector using composable menu components instead of the all-in-one ContextSelector, as documented here: https://www.patternfly.org/v4/demos/composable-menu/#context-selector-using-menu-components

ghjm avatar Jan 21 '22 16:01 ghjm